Ensure pytest configuration in pyproject.toml is picked up#7670
Ensure pytest configuration in pyproject.toml is picked up#7670lagru wants to merge 1 commit intoscikit-image:mainfrom
Conversation
Stepping out of the directory during tests might have been for the purpose of ensuring that the installed version is tested? Not sure if that is still necessary with the way we build and test. There's only one compiled version so if pytest tries to do the wrong thing, then it should fail and we should notice... Though I would feel more secure about this if we were using the SRC-layout.
Ah, apparently it was for the purpose of picking up the Cython modules... |
|
FWIW, the Pyodide/WASM CI job also suffers from the same hiccup, and One way to fix this and not move to a different folder when testing is to move to a (Apologies for the unsolicited suggestion, if it is one!) |
|
Not at all @agriyakhetarpal, thanks for the insight and digging up past mentions! I have a personal preference for the src-layout but I'm not sure what other core devs think. I'll add it as a discussion point to the next community meeting We currently do have an unadvertised In light of that, I'm suggesting pivot back to #7555 for a short-term fix. Long-term we hopefully get the time to clean up the basic structure of our CI somewhat (e.g. scratch the scripts in tools/github/). |
|
See #7555 |
4 participants
Description
Supersedes #7555. Closes #7554.Edit: #7555 might actually be the better short-term fix after all.
Stepping out of the directory during tests might have been for the purpose of ensuring that the installed version is tested? Not sure if that is still necessary with the way we build and test. There's only one compiled version so if pytest tries to do the wrong thing, then it should fail and we should notice...
Though I would feel more secure about this if we were using the SRC-layout.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.