Test docs & gallery on Windows (Azure) only for main#7658
Test docs & gallery on Windows (Azure) only for main#7658lagru wants to merge 1 commit intoscikit-image:mainfrom
main#7658Conversation
The Azure jobs testing our documentation are still the longest running jobs in our CI: ~40 min or longer. As a first step, I'd like to exclude them from running for every PR. That should get the iteration time for PRs down to 20 min. @stefanv, suggested to disable them altogether. I'm not sure yet how I feel about that. Since we do still tell contributors how to build the docs on Windows, I do want to ensure that that keeps working. So for now, I propose this compromise which keeps building the docs on `main`.
lagru
force-pushed
the
no-win-docs-on-prs
branch
from
588de2a to
ba1ac26
Compare
mkcor
left a comment
mkcor
left a comment
There was a problem hiding this comment.
This compromise sounds reasonable to me.
|
Note also the comment thread on lagru@588de2a#commitcomment-151225646 which is not visible in this PR. |
|
I would prefer disabling them to only running them on main or just running a cron job. I don't think it makes sense to only run certain tests after we merge to main. |
|
While get that, I really don't want to end up debugging what's going wrong with some contributor trying to build the docs on Windows down the line. Or even worse, dissuade them from contributing because they are frustrated with part the contribution guide being broken for them. Since the status quo has been testing the docs on Windows for a long time now, could we perhaps try this compromise as a first step and see how we fare? We can very easily remove them later on. The reverse might not be as trivial after some time... |
|
Obsolete now with recent switch from Azure to GitLab's CI. 🥳 |
|
Even though, as I notice, we are currently not testing the docs on Windows at all. Not my default choice but it doesn't seem like a big priority compared to other bigger fish. 😉 |
3 participants
Description
The Azure jobs testing our documentation are still the longest running jobs in our CI: ~40 min or longer. As a first step, I'd like to exclude them from running for every PR. That should get the iteration time for PRs down to 20 min (building the package will be the biggest contributor to runtime after than).
@stefanv, suggested to disable them altogether. I'm not sure yet how I feel about that. Since we have contributors on Windows, I do want to ensure that that building the docs locally keeps working for them.
So for now, I propose this compromise which skips in PRs and keeps building the docs on
main.Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.