Make apigen.py work with editable hooks#7647
Merged
stefanv merged 1 commit intoscikit-image:mainfrom Jan 8, 2025
Merged
Conversation
apigen.py in the previous form wasn't able to deal with skimage if it was installed in editable mode using a _scikit-image_editable_loader hook. In that case `root_module.__path__[-1]` would point to an invalid directory. This fix aims to (a) account for this by falling back to the __file__ attribute and (b) adds some defensive checks so we are not suprised in the future when something breaks. Longterm this part of our tooling could probably use some love, it seems a bit brittle.
5 tasks
Member
Author
Member
|
I recall that EDIT: Played around with it, and I don't immediately know how to apply it, so will merge this to get things working. |
stefanv
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
apigen.py in the previous form wasn't able to deal with skimage if it was installed in editable mode using a _scikit-image_editable_loader hook. In that case
root_module.__path__[-1]would point to an invalid directory.This fix aims to (a) account for this by falling back to the file attribute and (b) adds some defensive checks so we are not suprised in the future when something breaks.
Longterm this part of our tooling could probably use some love, it seems a bit brittle.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.