Use trusted publisher#7178
Merged
jarrodmillman merged 1 commit intoscikit-image:mainfrom Sep 30, 2023
Merged
Conversation
jarrodmillman
added
the
🔧 type: Maintenance
stefanv
approved these changes
Sep 30, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 0.22.0rc0 wheels and source tarball didn't get uploaded to PyPI because
I enabled GH as a trusted publisher for PyPI:
I tested this approach with devstats:
scientific-python/devstats#39
It seemed to work except that I ran into this issue:
But I believe
long_descriptionfrom setup.py was replaced withreadmein pyproject.toml:https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#readme
It doesn't cause an error and everything got uploaded to PyPI, but I thought that the readme from pyproject.toml would populate the
Project descriptionhere:https://pypi.org/project/devstats/
I will test this out with 0.22.0rc1.