Don't test numpy nightlies due to transcendental functions issue #6973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
added
the
🔧 type: Maintenance
lagru
changed the title
jarrodmillman
changed the title
lagru
approved these changes
May 31, 2023
Member
lagru
left a comment
lagru
left a comment
There was a problem hiding this comment.
Approving on the condition of a green CI.
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jun 1, 2023
This was referenced Jun 1, 2023
Merged
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jun 26, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jun 30, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jul 8, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jul 9, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Jul 9, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Aug 1, 2023
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Aug 14, 2023
jarrodmillman
added a commit
that referenced
this pull request
Aug 17, 2023
* Fix for NumPy 1.25 * Revert #6973 * Revert "Don't test numpy prerelease on azure (#6996)" This reverts commit e57c23d. * Skip warning check on older, noisier versions of NumPy * Remove upperpin * Use stable sort in _raveled_offsets_and_distances NumPy enabled optimizations for quicksort on AVX-512 enabled processors [1]. We sort based on neighbor distances which can be equal. The default quicksort is not stable and could have different behavior on AVX-512. Test this assumption. [1] https://numpy.org/devdocs/release/1.25.0-notes.html#faster-np-argsort-on-avx-512-enabled-processors * Fix forgotten doctest in _offsets_to_raveled_neighbors after updating to stable sort internally. * Fix for NumPy 1.25 * Revert #6973 * Revert "Don't test numpy prerelease on azure (#6996)" This reverts commit e57c23d. * Skip warning check on older, noisier versions of NumPy * Remove upperpin * Use stable sort in _raveled_offsets_and_distances NumPy enabled optimizations for quicksort on AVX-512 enabled processors [1]. We sort based on neighbor distances which can be equal. The default quicksort is not stable and could have different behavior on AVX-512. Test this assumption. [1] https://numpy.org/devdocs/release/1.25.0-notes.html#faster-np-argsort-on-avx-512-enabled-processors * Fix forgotten doctest in _offsets_to_raveled_neighbors after updating to stable sort internally. * Handle rank>0 scalar arrays numpy/numpy#10404 * Use stable sort * Use stable sort in max_tree (debug) See if it does anything. * Use stable sort in _get_high_intensity_peaks (debug) See if it does anything. * Upper pin numpy<1.26 for tests --------- Co-authored-by: Stefan van der Walt <[email protected]> Co-authored-by: Lars Grüter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorted
Description
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.