Fix NumPy 1.25 deprecation warnings #6969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
added
the
🔧 type: Maintenance
jarrodmillman
force-pushed
the
numpy-1.25-deprecations
branch
from
0812663 to
74d533c
Compare
jni
reviewed
May 31, 2023
Comment on lines
+33
to
+34
| perl -pi -e 's/numpy>=1.21.1/numpy>=1.21.1,<1.25/g' requirements/default.txt | ||
| perl -pi -e 's/numpy>=1.21.1/numpy>=1.21.1,<1.25/g' requirements/build.txt |
Contributor
Author
There was a problem hiding this comment.
Those lines disable testing on NumPy 1.25. That is the point of 74d533c.
Without that the tests will continue to fail on main and on all PRs from main. The idea is to merge this PR and make a PR to remove those lines and figure out how to fix the remaining errors with NumPy 1.25.
stefanv
approved these changes
May 31, 2023
Member
stefanv
left a comment
stefanv
left a comment
There was a problem hiding this comment.
Suggested a different spelling of all, otherwise LGTM.
Co-authored-by: Stefan van der Walt <[email protected]>
Merged
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
np.alltrueandnp.productdeprecation warnings for NumPy 1.25. It also disables testing on NumPy 1.25 due to changes that need to be more closely examined. If merged, I will create a new PR removing the NumPy upper pin for testing so we can sort through the issue without making the main branch and every new PR fail due to this known issue.