Display plotly figures from gallery example even when running script at CLI.#5347
Merged
rfezzani merged 2 commits intoscikit-image:mainfrom Apr 23, 2021
Merged
Display plotly figures from gallery example even when running script at CLI.#5347rfezzani merged 2 commits intoscikit-image:mainfrom
rfezzani merged 2 commits intoscikit-image:mainfrom
Conversation
Member
Author
|
This PR also fixes the thumbnail issue (thumbnail wouldn't display when it was a Plotly figure), see now: https://1745-2014929-gh.circle-artifacts.com/0/doc/build/html/auto_examples/index.html |
jni
approved these changes
Apr 23, 2021
Member
jni
left a comment
jni
left a comment
There was a problem hiding this comment.
Ha! Ignore my comments in your other PR! 🤦 😅
rfezzani
approved these changes
Apr 23, 2021
tupui
pushed a commit
to tupui/scikit-image
that referenced
this pull request
Apr 27, 2021
…at CLI. (scikit-image#5347) * Revert "set plotly renderer in conf.py" This reverts commit 805050a. * Display plotly figures when running script at CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hurray! The fix came from reverting 805050a (which conflicted with 37bff40).
Now, example https://scikit-image.org/docs/dev/auto_examples/data/plot_3d.html renders properly in the gallery!
And users will be able to run
$ python examples/applications/plot_3d_interaction.pyand have all the figures display.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.