example to show the 3d dataset#5120
Conversation
|
Hello @emmanuelle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-12-30 10:49:45 UTC |
mkcor
left a comment
mkcor
left a comment
There was a problem hiding this comment.
Wonderful! I will link to this example whenever I use the dataset in question in other examples.
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
| binary_string=True, binary_format='jpg') | ||
| fig.layout.annotations[0]['text'] = 'Cell membranes' | ||
| fig.layout.annotations[1]['text'] = 'Nuclei' | ||
| plotly.io.show(fig) |
There was a problem hiding this comment.
For my personal understanding, why isn't fig.show() enough in this case? I have checked locally that it isn't indeed, but I don't know why. 😯 Thanks!
|
The test fail is unrelated to this PR. @jni I remember you mentioning that docs-only PR required only one approving review before merging? Under https://scikit-image.org/docs/stable/contribute.html#guidelines, I'm reading that "No changes are ever committed [to master] without review and approval by two core team members" so I'm hesitant... Should we update these guidelines? |
grlee77
left a comment
grlee77
left a comment
There was a problem hiding this comment.
Thanks, Emma. The doc artifact for this looks good. Very convenient to have that in the PR now!
| ipywidgets | ||
| plotly>=4.10.0 | ||
| plotly>=4.14.0 | ||
| kaleido |
There was a problem hiding this comment.
I wasn't familiar with kaleido, but it looks like plotly uses it for static image export when it is available.
There was a problem hiding this comment.
I would be +1 on updating the guidelines there. One approving review seems sufficient for doc PRs. I think it is mainly PRs involving API changes where it is important to get consensus from multiple reviewers. That said, we now have 2 approvals here if you want to hit the green button! |
|
Ok, done! Thanks, @grlee77 -- will submit an update to the contribution guidelines. |
4 participants
This new gallery example shows the 3d dataset which has been recently introduced.
See for example https://1138-2014929-gh.circle-artifacts.com/0/doc/build/html/auto_examples/data/plot_3d.html#sphx-glr-auto-examples-data-plot-3d-py