Fix deprecated option in sphinx that causes warning treated as error in travis #2395

sciunto · 2016-12-08T10:46:24Z

See #2371

Closes #2401

Ref:

soupault

Thanks!

sciunto · 2016-12-08T15:21:34Z

Looks like there is several evolutions in sphinx.

Right now, I have this message

Exception occurred:

  File "/home/travis/build/scikit-image/scikit-image/doc/source/../ext/sphinx_gallery/docs_resolv.py", line 48, in _get_data

    with open(url, 'r') as fid:

IOError: [Errno 2] No such file or directory: '/home/travis/build/scikit-image/scikit-image/doc/build/html/api/skimage.color.rst.html'

The full traceback has been saved in /tmp/sphinx-err-yAUWXd.log, if you want to report the issue to the developers.

Please also report this if it was a user error, so that a better error message can be provided next time.

A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

It deserves some investigations... ping @sphinx-gallery (not sure if this is relevant: sphinx-gallery/sphinx-gallery#58)

JDWarner · 2016-12-12T20:29:20Z

Sphinx broke this in version 1.5, their logic for warning checking has (had) a typo. I reported it here and it's now fixed in master: sphinx-doc/sphinx#3204

The workaround is either to use Sphinx from master until they release a version with the fix, or allow Travis to pass with Sphinx errors in the interim.

sciunto · 2016-12-12T21:00:49Z

Thanks @JDWarner for your comment but actually, I already went through that one, no? (And i didn't noticed the typo). My problem is more with sphinx-gallery now.

sciunto · 2016-12-13T10:37:01Z

I updated sphinx-gallery, a bug fix release for sphinx 1.5.

emmanuelle · 2016-12-20T09:39:28Z

Thanks @sciunto ! For the sphinx-gallery files, did you copy them from the latest sphinx-gallery release (or from master), or is there some divergence between the files in scikit-image and the ones in sphinx-gallery ?

sciunto · 2016-12-20T09:59:21Z

@emmanuelle I copied them, and I didn't modify any of them.

emmanuelle · 2016-12-20T12:30:34Z

OK, great. At some point we can consider adding sphinx-gallery as a dependency, but there's no hurry to do it. Two questions:

any idea why Travis still fails?
with the new sphinx-gallery, did you build the gallery to check that it still looks good?

sciunto · 2016-12-20T14:16:05Z

@emmanuelle Did you read the ticket I opened upstream? Before going into more investigations, we were wondering if there was modifications that you brought in our copy of sphinx gallery that were not included upstream? I guess you would never have done that, except perhaps by mistake...

sciunto · 2016-12-20T14:22:21Z

PS: the problem also exists on my desktop. Nevertheless, the gallery looks good as it happens at the very end for the generation of hyperlinks.

emmanuelle · 2016-12-20T14:56:43Z

@sciunto is it sphinx-gallery/sphinx-gallery#184? When I ported the gallery to sphinx-gallery (#2078) I had to modify at least one file but I back-ported it to sphinx-gallery (sphinx-gallery/sphinx-gallery#119, which has been merged).

emmanuelle · 2016-12-21T10:23:15Z

As suggested by @JDWarner should we allow Travis to pass with sphinx warnings until the problem is solved? It's blocking a number of PRs in the meantime...

sciunto · 2016-12-21T10:28:26Z

Thanks for the clarifications @emmanuelle

We can do that. I don't know where is this option to do not treat warning as errors. If you give me a hint, I can do it in this PR. At least, this PR solves problems related to our configuration and the latest sphinx evolutions. It could be merged imho. For the rest, upstream is currently looking at it. I can open another ticket to follow the progress.

sciunto · 2016-12-21T16:54:53Z

A patch is in the pipes...

sciunto · 2016-12-21T18:02:01Z

@emmanuelle @soupault The build goes fine on my side. Ready to go!

codecov-io · 2016-12-21T18:41:32Z

Current coverage is 90.64% (diff: 100%)

No coverage report found for master at 9d7fcca.

Powered by Codecov. Last update 9d7fcca...eac6f6a

Borda · 2016-12-22T12:08:50Z

it seems ready to merge, right? :)

sciunto · 2016-12-22T12:25:05Z

Let's ping @scikit-image/core to see if someone can press the green button :)

Outdated

soupault · 2016-12-22T13:06:13Z

doc/ext/sphinx_gallery/__init__.py

 """
 import os
-__version__ = '0.1.2'
+__version__ = '0.1.7'


If I understood correctly, the update in this PR contains sphinx-gallery 0.1.7+sphinx-gallery/sphinx-gallery#190 .
If it is indeed so, I'd suggest either to wait for that patch being merged, or to note somewhere the details regarding the version used.

I think it's more urgent to have Travis passing again.

sciunto · 2016-12-22T13:55:17Z

@soupault My plan is to re-update sphinx-gallery before the release... I open a ticket for that, assigned to myself.

sciunto · 2016-12-22T14:00:40Z

The idea is to be get travis back to work for other PRs.

emmanuelle · 2016-12-22T16:55:08Z

@sciunto in addition to the open ticket, can you add a line in TODO.txt as well?

sciunto · 2016-12-22T20:03:21Z

Oki, it's done :)

emmanuelle

LGTM!

emmanuelle · 2016-12-23T11:10:34Z

Merging, thanks!

soupault · 2016-12-23T20:40:13Z

LGTM as well.

sciunto changed the title ~~Fix deprecated option~~ Fix deprecated option in sphinx that causes warning treated as error in travis Dec 8, 2016

sciunto requested a review from soupault December 8, 2016 10:47

sciunto mentioned this pull request Dec 8, 2016

add init params for Ellipse & Circle and RANSAC #2371

Closed

4 tasks

sciunto added 🔧 type: Maintenance Refactoring and maintenance of internals 🧐 Needs review labels Dec 8, 2016

soupault previously approved these changes Dec 8, 2016

View reviewed changes

soupault mentioned this pull request Dec 12, 2016

travis env is in bad shape -- all fail due to sphinx config #2401

Closed

sciunto mentioned this pull request Dec 12, 2016

Exception occurred in _get_data (IOError) sphinx-gallery/sphinx-gallery#184

Closed

sciunto assigned emmanuelle Dec 13, 2016

sciunto force-pushed the sphinx_option branch from fbaeb4e to dbc8171 Compare December 13, 2016 12:11

Borda mentioned this pull request Dec 15, 2016

stable ellipse fitting #2394

Merged

2 tasks

soupault mentioned this pull request Dec 17, 2016

Fix reference to travis notes #2403

Merged

sciunto mentioned this pull request Dec 21, 2016

[sphinx 1.5] _gdbm.error No such file or directory sphinx-gallery/sphinx-gallery#186

Closed

sciunto added the 💪 Work in progress label Dec 21, 2016

sciunto removed the 🧐 Needs review label Dec 21, 2016

sciunto added 2 commits December 21, 2016 18:27

Fix deprecated option

2212522

Fix sphinx deprecation

79e7d31

sciunto added 2 commits December 21, 2016 18:27

MAINT: update sphinx-gallery to v0.1.7 for sphinx 1.5

5c2b156

Add patch from upstream (sphinx-gallery)

82b2fc3

sciunto force-pushed the sphinx_option branch from eac6f6a to 82b2fc3 Compare December 21, 2016 17:27

sciunto added 📄 type: Documentation Updates, fixes and additions to documentation 🧐 Needs review and removed 💪 Work in progress labels Dec 21, 2016

soupault self-assigned this Dec 22, 2016

sciunto mentioned this pull request Dec 22, 2016

[MRG] Better path handling sphinx-gallery/sphinx-gallery#190

Merged

soupault reviewed Dec 22, 2016

View reviewed changes

sciunto mentioned this pull request Dec 22, 2016

Update sphinx-gallery before release 0.13 #2410

Closed

Add task in TODO.txt (update sphinx gallery)

b5a34cb

blink1073 mentioned this pull request Dec 22, 2016

Make the img_num argument optional #2054

Merged

emmanuelle approved these changes Dec 23, 2016

View reviewed changes

emmanuelle merged commit 5997cb0 into scikit-image:master Dec 23, 2016

emmanuelle mentioned this pull request Dec 23, 2016

BF: Initialize firstbg to the numels so if no bg value found, second loop is not executed #2399

Closed

sciunto deleted the sphinx_option branch December 23, 2016 20:45

Uh oh!

Fix deprecated option in sphinx that causes warning treated as error in travis #2395

Fix deprecated option in sphinx that causes warning treated as error in travis #2395

Uh oh!

Conversation

sciunto commented Dec 8, 2016 • edited by emmanuelle Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soupault left a comment

Choose a reason for hiding this comment

Uh oh!

sciunto commented Dec 8, 2016

Uh oh!

JDWarner commented Dec 12, 2016

Uh oh!

sciunto commented Dec 12, 2016

Uh oh!

sciunto commented Dec 13, 2016

Uh oh!

emmanuelle commented Dec 20, 2016

Uh oh!

sciunto commented Dec 20, 2016

Uh oh!

emmanuelle commented Dec 20, 2016

Uh oh!

sciunto commented Dec 20, 2016

Uh oh!

sciunto commented Dec 20, 2016

Uh oh!

emmanuelle commented Dec 20, 2016

Uh oh!

emmanuelle commented Dec 21, 2016

Uh oh!

sciunto commented Dec 21, 2016

Uh oh!

sciunto commented Dec 21, 2016

Uh oh!

sciunto commented Dec 21, 2016

Uh oh!

codecov-io commented Dec 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 90.64% (diff: 100%)

Uh oh!

Borda commented Dec 22, 2016

Uh oh!

sciunto commented Dec 22, 2016

Uh oh!

soupault Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

emmanuelle Dec 22, 2016

Choose a reason for hiding this comment

Uh oh!

sciunto commented Dec 22, 2016

Uh oh!

sciunto commented Dec 22, 2016

Uh oh!

emmanuelle commented Dec 22, 2016

Uh oh!

sciunto commented Dec 22, 2016

Uh oh!

emmanuelle left a comment

Choose a reason for hiding this comment

Uh oh!

emmanuelle commented Dec 23, 2016

Uh oh!

soupault commented Dec 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sciunto commented Dec 8, 2016 •

edited by emmanuelle

Loading

codecov-io commented Dec 21, 2016 •

edited

Loading