add init params for Ellipse & Circle and RANSAC #2371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array is passed into features.local_binary_pattern
added init params to ransac
…scikit-image into add_init_params_fitModels Conflicts: skimage/measure/fit.py
Contributor
Author
|
@sciunto I passed the rebase again, but still it shows change over all other files (+2,272 lines −1,005 lines) |
Member
|
I think you do something wrong each time you rebase. You have commits with the same message with different hashes... The better is to start a new PR on a new branch (either manually or if you are confident enough with git, cherry pick) |
Borda
added a commit
to Borda/scikit-image
that referenced
this pull request
Dec 24, 2016
Contributor
Author
|
The last version was moved to #2415 |
Borda
added a commit
to Borda/scikit-image
that referenced
this pull request
Dec 24, 2016
note, copy last version from PR scikit-image#2371 fix decimal imprecision -> np.round(, decimals=2) review update update explanation for A[2, :] = -1 in estimate CircleModel
Borda
added a commit
to Borda/scikit-image
that referenced
this pull request
Dec 29, 2016
note, copy last version from PR scikit-image#2371 fix decimal imprecision -> np.round(, decimals=2) review update update explanation for A[2, :] = -1 in estimate CircleModel update range for min number
Borda
added a commit
to Borda/scikit-image
that referenced
this pull request
Jan 30, 2017
note, copy last version from PR scikit-image#2371 fix decimal imprecision -> np.round(, decimals=2) review update update explanation for A[2, :] = -1 in estimate CircleModel update range for min number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding option to use some init parameters for model fitting, eg, you have some a priory knowledge, you do not want to use some default parameters
Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
./doc/examples(new features only)[For detailed information on these and other aspects see scikit-image contribution guidelines]