Conversation
henryiii
commented
Mar 9, 2021
|
|
||
|
|
||
| protocol_version = 1 | ||
| protocol_version = (1, 1) |
Member
Author
There was a problem hiding this comment.
The protocol version is now a tuple, to allow minor updates
Member
Author
|
This also fixes the enum vs string problem! A sting enum wasn't allowed for |
Member
Author
|
Passing in boost-histogram locally, so will merge and make a patch release, as there are no functional changes, just removing functionality that was not supposed to be required. |
Member
|
Sounds good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HDembinski, @jpivarski Important fix to the protocol. The old version required writable properties for axes, kind, and traits. 🤦 . This only requires they be readable properties now. (If they are writable, it does not invalidate the protocol, but it is not required! Not discovered by mplhep usage because the mini-NumPy wrapper happened to have writable properties).
I'd also like to update the protocol to require returning np.ndarray from .values() and such, as you should be a bit more explicit on return types, and less explicit on accepted types. Now that
ArrayLikeis available, I realize you should only "accept" ArrayLike, and never return it, it's too broad for a return usually.