feat: Rework CMake search path settings#880
Merged
henryiii merged 3 commits intoscikit-build:mainfrom Feb 25, 2025
Merged
Conversation
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
2 times, most recently
from
6b44e12 to
a178c3b
Compare
LecrisUT
changed the title
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
2 times, most recently
from
81742a7 to
c9454cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 83.90% 83.62% -0.29%
==========================================
Files 74 75 +1
Lines 4387 4451 +64
==========================================
+ Hits 3681 3722 +41
- Misses 706 729 +23 ☔ View full report in Codecov by Sentry. |
LecrisUT
commented
Aug 29, 2024
docs/search_paths.md
Outdated
| This variable is populated from the entry-point `cmake.module` and the option | ||
| `search.modules` similar to [`CMAKE_PREFIX_PATH`] section. | ||
|
|
||
| [`CMAKE_PREFIX_PATH`]: #cmake-prefix-path |
Collaborator
Author
There was a problem hiding this comment.
This link does indeed work, but the CI is reporting as not working 🤷
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
2 times, most recently
from
5770c6a to
732eab5
Compare
LecrisUT
commented
Sep 3, 2024
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
2 times, most recently
from
659e0cb to
836c51e
Compare
LecrisUT
commented
Sep 3, 2024
Collaborator
|
(Sorry I'm a bit slow reviewing, classes start this week and I'm teaching again) |
henryiii
reviewed
Sep 6, 2024
henryiii
reviewed
Sep 6, 2024
henryiii
added a commit
that referenced
this pull request
Sep 10, 2024
Pulling out this fix from #880 for inclusion in a patch release. --------- Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
4 times, most recently
from
57514c7 to
a6bccfa
Compare
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
3 times, most recently
from
65dd0d7 to
d5a437e
Compare
Collaborator
|
Conflict, and were you planning any extra tests? |
henryiii
reviewed
Feb 24, 2025
henryiii
reviewed
Feb 24, 2025
Signed-off-by: Cristian Le <[email protected]> Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
from
d5a437e to
e8a5597
Compare
Collaborator
Author
Yeah, forgot about that one. Added the tests for |
Signed-off-by: Cristian Le <[email protected]> Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
feat/ignore-prefix
branch
from
c42678b to
1bbcf1a
Compare
henryiii
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entry_points(group="cmake.root"):cmake.rootovercmake.prefixCloses #831
Closes #885
Relates to #860 (still keeping it open because it doesn't address the specific issue)