Skip to content

ci: try 3.12 + numpy nightly wheels#463

Closed
henryiii wants to merge 1 commit intomainfrom
henryiii/ci/python3.12nighly
Closed

ci: try 3.12 + numpy nightly wheels#463
henryiii wants to merge 1 commit intomainfrom
henryiii/ci/python3.12nighly

Conversation

@henryiii
Copy link
Copy Markdown
Collaborator

Trying nightlies for NumPy. If it works, we should do this for .fmf.

@LecrisUT
Copy link
Copy Markdown
Collaborator

LecrisUT commented Aug 14, 2023

About tmt issues. I've noticed an issue is that it is downloading numpy instead of using the installed version 1.24.4. I'll make a PR fix for that (#464). Over there we should stick with the fedora packages instead of PyPI, otherwise there would be little information compared to the built-in CI. I could make it work with either if you find it useful though.

@henryiii henryiii force-pushed the henryiii/ci/python3.12nighly branch from 984bdc4 to 9a6f35a Compare August 14, 2023 14:26
@henryiii
Copy link
Copy Markdown
Collaborator Author

NumPy just released 3.12 wheels (1.26.0b1) without having to use the nightly wheelhouse, so this should be much easier now.

I'm guessing you are not disabling build isolation, which is why it's downloading the build environments (probably including a released version of scikit-build-core?). Probably would be better to disable build isolation and use only Fedora supplied packages, I think.

@LecrisUT
Copy link
Copy Markdown
Collaborator

I'm guessing you are not disabling build isolation, which is why it's downloading the build environments (probably including a released version of scikit-build-core?). Probably would be better to disable build isolation and use only Fedora supplied packages, I think.

Indeed, I forgot to add that. I've added both --no-build-isolation and --no-index in #464. That seems to fix the issue there even with numpy 1.24

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/ci/python3.12nighly branch from 9a6f35a to b2ed05e Compare August 14, 2023 14:50
@LecrisUT
Copy link
Copy Markdown
Collaborator

@henryiii can you merge #464 first and rebase this one on top of it? I think the dependencies won't be satisfied

@henryiii
Copy link
Copy Markdown
Collaborator Author

Since fedora builds older versions of NumPy for 3.12, adding this breaks the non-isolated builds. A better solution for testing then probably is to just enable pre-releases (PIP_PRE=1).

Closing in favor of #464.

@henryiii henryiii closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants