fix: FindNumPy should not call FindPythonLibs#958
Conversation
Codecov Report
@@ Coverage Diff @@
## main #958 +/- ##
==========================================
+ Coverage 80.57% 86.29% +5.72%
==========================================
Files 31 31
Lines 1560 1562 +2
Branches 283 343 +60
==========================================
+ Hits 1257 1348 +91
+ Misses 231 152 -79
+ Partials 72 62 -10 |
|
I have tested this on the manylinux image for myself and the build now succeeds, however there is still a message being printed which reads: While this is technically still true because there is no |
|
That warning is correct; on manylinux, there are no Python libs. Your users are not likely to be building on manylinux (since it's only for making wheels), so will probably not get that warning - most Python distributions do include the libs. The root problem I expect is PythonExtensions is calling FindPythonLibs, which triggers that warning. Maybe we can see if we can fix that. |
This should not be necessary. It should already be found, and even if not, PYTHON_EXECUTABLE is set and PYTHON_INCLUDE_DIR isn't important. I think this is causing #957, since you can't run FindPythonLibs REQUIRED on manylinux.