Skip to content

chore: use wheel tags cli#84

Merged
mayeut merged 4 commits intoscikit-build:masterfrom
mayeut:test-wheel-cli
Mar 15, 2023
Merged

chore: use wheel tags cli#84
mayeut merged 4 commits intoscikit-build:masterfrom
mayeut:test-wheel-cli

Conversation

@mayeut
Copy link
Copy Markdown
Contributor

@mayeut mayeut commented Oct 9, 2021

Try using pypa/wheel#422

@henryiii
Copy link
Copy Markdown
Contributor

I think this is now working on everyone except macOS, which currently breaks delocate due to wheel changes not related to this functionality. See pypa/wheel#433.

@henryiii henryiii force-pushed the test-wheel-cli branch 2 times, most recently from 747f724 to a54945c Compare March 14, 2023 20:00
@henryiii henryiii changed the title Try wheel cli chore: use wheel tags cli Mar 14, 2023
@henryiii henryiii marked this pull request as ready for review March 14, 2023 21:14
@jcfr
Copy link
Copy Markdown
Contributor

jcfr commented Mar 15, 2023

Moving away from jcfr/wheeltools.git@wheeltools-2018-10-28-a2f174d0e and getting ride of the converted script is really nice 💯

I am glad the wheel cli now support updating the tags 🙏

Also neat to see our packages featured in the examples at https://wheel.readthedocs.io/en/stable/reference/wheel_tags.html#examples

Thanks again @henryiii for adding the tags interface to the wheel cli 💯 👌

@mayeut mayeut merged commit 1de6e50 into scikit-build:master Mar 15, 2023
@mayeut mayeut deleted the test-wheel-cli branch October 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants