Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
I just shared feedback with the CMake team explaining the situation. In a nutshell, I mentioned it would be ideal to update the Kitware fork based of version
I will follow-up once we discussed it and settle on a path forward. |
|
The PR for |
|
Ditto. Here is what we discussed with @bradking
Switching to the updated Kitware fork with the backported classic job server is then a sensible path forward. |
|
The test failing on Windows seems to be coming from the jobserver patch in Kitware fork which does not make the test expected result depend on the platform: Kitware/ninja@8879a03#diff-4a3129d062b73d6f6436e3d4e5e3f41bbb848ef49cce54309fe6a00b6f93d132 c.f. Kitware/ninja#3 |
Ran
nox -s bump -- --upstream-repository Kitware/ninja.The Kitware fork adds the following feature compared to upstream:
make-4.3-jobserver-1: Based on this release, which includes pipe-based jobserver support for Make 4.3 and was conveniently created by the same developer who upstreamed jobserver support