Conversation
Removed initial cache file generation for CMAKE_C_FLAGS and CMAKE_EXE_LINKER_FLAGS.
mayeut
approved these changes
Feb 28, 2026
Contributor
mayeut
left a comment
mayeut
left a comment
There was a problem hiding this comment.
LGTM.
It indeed seems like a very old workaround that should not be needed anymore.
mayeut
reviewed
Feb 28, 2026
mayeut
previously requested changes
Feb 28, 2026
Removed unused variable from CMake configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed initial cache file generation for CMAKE_C_FLAGS and CMAKE_EXE_LINKER_FLAGS.
See #457, should fix OpenBSD. Pretty sure it's no longer needed.