fix: Application bundle integrity issues on macOS 13#304
Merged
henryiii merged 1 commit intoscikit-build:masterfrom Oct 31, 2022
Merged
fix: Application bundle integrity issues on macOS 13#304henryiii merged 1 commit intoscikit-build:masterfrom
henryiii merged 1 commit intoscikit-build:masterfrom
Conversation
Contributor
|
That seem reasonable. I know that the zip module in Python does not support symbolic links. Scikit-build doesn’t handle them either. This would explain the “damaged” message. |
This commit unbundles the macOS app to keep only what's really needed & get rid of the GUI stuff.
mayeut
force-pushed
the
macos-unbundle-app
branch
from
3693ec2 to
71330d8
Compare
Contributor
Author
|
I'll try to use it a bit more but some first tests on my laptop with the wheel produced by GHA works. |
henryiii
approved these changes
Oct 31, 2022
Contributor
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
This fixes the issue for me, too, using the wheel locally.
Member
|
Thank you @mayeut ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unbundles the macOS app to keep only what's really needed & get rid of the GUI stuff.
fix #301