Enable win-arm64 by x86-emulated version#231
Merged
henryiii merged 1 commit intoscikit-build:masterfrom Mar 21, 2022
Merged
Conversation
Currently there is no win-arm64 CMake release yet, but x86 emulated version is working properly. As soon as CMake is released for win-arm64, that binary should be targeted.
Contributor
Author
|
@henryiii Could you take a look on that? |
Contributor
|
Seems reasonable. |
Contributor
Author
|
@henryiii thanks for the quick cooperation! Could you estimate when it will be released at pypi? |
Contributor
|
3.23 is about out, probably then? We match numbering schemes, so doing patch releases on patch releases is not ideal if it's easy to avoid. |
Contributor
Author
|
Thanks, next release (3.23) sounds great! |
Contributor
|
3.23 is stuck due to loss of manylinux1 support, but 3.22.4 will have this (tomorrow, probably) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no win-arm64 CMake release yet, but x86 emulated version is working properly.
As soon as CMake is released for win-arm64, that binary should be targeted.