fix: build with CMAKE_CXX_STANDARD:STRING=11 on linux#222
fix: build with CMAKE_CXX_STANDARD:STRING=11 on linux#222mayeut merged 3 commits intoscikit-build:masterfrom
Conversation
The CMake test suite doesn't pass when using the default detection mechanism on manylinux2014. The CMake test suite is now run when building from sources.
Default is to exclude only `BootstrapTest` On musllinux, also exclude `ExportImport`, `RunCMake.install` & `RunCMake.file-GET_RUNTIME_DEPENDENCIES`
01b3c2d to
0a46b56
Compare
|
I had to disable some tests for musllinux & opened a discussion about that at https://discourse.cmake.org/t/cmake-test-suite-failing-on-alpine-linux/5064 |
henryiii
left a comment
There was a problem hiding this comment.
Travis times out after 2/3 of the tests. Can we reduce there?
I missed that. I thought it was only due to "negative credit balance" given the previous build passed without issues. Let's get this in as-is to get the fix in & go on from there then. |
|
Tests are showing both timeouts & failures with qemu builds. I'll try to address that "quickly" (given the time it takes with QEMU and that it might require a few trials...) |
The CMake test suite doesn't pass when using the default detection mechanism on manylinux2014.
The CMake test suite is now run when building from sources.
This is using c++11 rather than c++14 because it's available on both manylinux1 & manylinux2014.
fixes #221