CI: fix spelling of test package name #79
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
approved these changes
Apr 17, 2024
Member
|
Ah yes. In
Nice. |
|
I thought hatchling has normalized SDist names for among time? Setuptools just changed to do it too, but I though hatching basically always did it? |
|
Yes, it’s setuptools: All the other build backends have done this since nearly the beginning. |
Member
|
Oh right. I just totally forgot that I had to use edit: This is still the case for upload-nightly-action/conda-lock.yml Lines 49 to 50 in a5d8097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python -m build --outdir ./dist tests/test_packagenow createstest_package-0.0.1.tar.gzandtest_package-0.0.1-py3-none-any.whlthus this PR fixes the spelling for the CI to pass.