CI: Add test for uploads with multiple labels #54
Conversation
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
* Add test uploads for non-main label 'test' and for multiple labels in a comma seperated list. As attempting to apply multiple labels through repeated upload of the same package will fail as the package already exists, bump the version number of the test package to generate multiple packages that can be uploaded with different labels.
matthewfeickert
force-pushed
the
ci/test-lables
branch
from
ce721d8 to
f41df7e
Compare
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
matthewfeickert
left a comment
matthewfeickert
left a comment
There was a problem hiding this comment.
If we wanted to also check what labels are uploaded as a validation step in cleanup before removing them we could add something like
curl --silent https://api.anaconda.org/package/scientific-python-nightly-wheels/test-package | \
jq -r '.releases[].version' > package-versions.txt
for package_version in $(cat package-versions.txt); do
echo "# scientific-python-nightly-wheels/test-package version ${package_version} labels:"
curl --silent https://api.anaconda.org/package/scientific-python-nightly-wheels/test-package | \
jq -r '.files[] | \
select( .version == "${package_version}" )' | \
jq -r '.labels'
donebut I don't think that's strictly necessary, so I've left this out.
| run: | | ||
| # Bump version to avoid wheel name conflicts | ||
| sed -i 's/0.0.1/0.0.2/g' tests/test_package/pyproject.toml | ||
| rm ./dist/* | ||
| python -m build --outdir ./dist tests/test_package |
There was a problem hiding this comment.
As attempting to apply multiple labels through repeated upload of the same package will fail as the package already exists, bump the version number of the test package to generate multiple packages that can be uploaded with different labels.
matthewfeickert
requested review from
a team and
bsipocz
and removed request for
bsipocz
| - name: Build a wheel and a sdist | ||
| run: | | ||
| PYTHONWARNINGS=error,default::DeprecationWarning python -m build --outdir ./dist tests/test_package | ||
| python -m build --outdir ./dist tests/test_package |
There was a problem hiding this comment.
Removing this as I had added in previously from another workflow I have, but we don't care if there are deprecation warnings in the package build tools, as we just need an artifact to upload.
There was a problem hiding this comment.
that assumes that the command will keep working as is, which I think is a valid assumption (or will be a super simple fix many years down the line), so 👍
There was a problem hiding this comment.
Yeah, the main reason I removed this is that I've had this check in other work flows and this has ended up causing things to fail for reasons unrelated to build itself (e.g. a build backend deprecating something for the future but that warning still getting caught). I agree that if build ends up having issues though we will not be the first to catch it. :)
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
I only have extreme nitpicks, and also wondered about the same thing you wrote whether the labels need to be verified. I don't necessarily think, so would say go ahead and merge this without that check.
| - name: Build a wheel and a sdist | ||
| run: | | ||
| PYTHONWARNINGS=error,default::DeprecationWarning python -m build --outdir ./dist tests/test_package | ||
| python -m build --outdir ./dist tests/test_package |
There was a problem hiding this comment.
that assumes that the command will keep working as is, which I think is a valid assumption (or will be a super simple fix many years down the line), so 👍
Co-authored-by: Brigitta Sipőcz <[email protected]>
Co-authored-by: Brigitta Sipőcz <[email protected]>
matthewfeickert
temporarily deployed
to
remove-old-wheels
GitHub Actions
Inactive
Add test uploads for non-main label 'test' and for multiple labels in a comma seperated list to compliment the feature added in PR #47.
This is an example of things working as intended prior to the cleanup step removing the test package.