ENH: adding list of packages to exclude from cleanup #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
requested changes
Aug 15, 2023
Member
matthewfeickert
left a comment
matthewfeickert
left a comment
There was a problem hiding this comment.
Two small suggestions to make is easier for future packages to be tested (if needed). Otherwise thanks and looks good.
Member
|
The reason the CI will fail regardless of checkout is described in #32 (comment) |
jarrodmillman
approved these changes
Aug 16, 2023
|
Perhaps the retention policy should be mentioned in the README.md as well? |
Member
Author
|
Yeah, good point, I'll add it there, too. |
Member
Author
|
Given the one approval, and the discussion on the rest, I go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add a file to host the agreed upon exceptions for the cleanups. Neither the number version nor the date based cleanup will run for these.
CI is expected to fail as
Fixes #34
cc @mattip