-
Notifications
You must be signed in to change notification settings - Fork 13
Description
At the moment the package index to upload the distributions is hardcoded to https://anaconda.org/scientific-python-nightly-wheels
upload-nightly-action/entrypoint.sh
Line 17 in 80af44f
| ANACONDA_ORG="scientific-python-nightly-wheels" |
Related to #5 (comment), this should not be hardcoded as there are additional nightly package indexes that can reasonably be desired to be used. As an explicit example, at the moment matplotlib uploads nightly wheels to https://anaconda.org/scipy-wheels-nightly (@tacaswell @QuLogic I'm not sure if there was discussion at the 2023 summit about switching where you do nightly uploads to, so I'll let you comment here).
You may be very reasonably wondering why there is an https://anaconda.org/scientific-python-nightly-wheels/matplotlib if that's not where matplotlib publishes their nightlies, and then answer is that while I was working on https://github.com/scientific-python/nightly-wheels @jarrodmillman had freshly made https://anaconda.org/scientific-python-nightly-wheels/ and to do tests of the action workflow I used matplotlib as I already had that working well for matplotlib on the scipy-wheels-nightly Anaconda org.
@tacaswell @QuLogic I have a private IRIS-HEP Slack chat with @tacaswell from 2022-08-19 where I got permission to use matplotlib as a test upload (just wanted to make it very clear I wasn't going about distributing packages without express approval).
So this also means that until this feature is added
upload-nightly-action/README.md
Line 32 in 80af44f
| python -m pip install matplotlib --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --upgrade --pre |
and
upload-nightly-action/README.md
Lines 49 to 54 in 80af44f
| name: test | |
| dependencies: | |
| - pip | |
| - pip: | |
| - --pre --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple | |
| - matplotlib |
are wrong (well, at least severely out of date) and matplotlib should not be used as an example.
If people are in agreement with me that this should be configurable (I would argue that unless you want this to be insular to only the Scientific Python org community this should not have a default but be a required argument) I'm happy to PR this.