feat(webapp): support directory path#359
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds webapp parity with the CLI’s “package directory” support by letting users target a subdirectory within a GitHub repo for analysis, and updates local serving/docs accordingly.
Changes:
- Thread a new
subdir/packageDirparameter through the Pyodide execution path (prefetch → collect → process). - Add
packageDirto webapp state, URL query persistence, and the UI form. - Add a
bun run servehelper and update docs/example URLs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/repo-review-app/utils/pyodide.ts | Passes subdir into Python process_prefetch_files, collect_all, and process. |
| src/repo-review-app/repo-review-app.tsx | Introduces packageDir state/UI and forwards it into the Pyodide pipeline; persists it in the URL. |
| package.json | Adds a serve script for local build + static hosting. |
| docs/webapp.md | Documents the new packageDir URL parameter with an example link. |
| docs/_static/scripts/index.html | Adds an explicit <!doctype html> declaration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henryiii
force-pushed
the
henryiii/feat/webapppath
branch
from
7a3164f to
c486dba
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Strip leading slashes and reject any segment that is ".." before setting the query param or passing the value into Pyodide. Co-authored-by: Copilot <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/webapppath
branch
from
8f4bc94 to
1f1d966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is supported by the CLI, but not the webapp.
Also touched up local serving a little,
bun run servestarted. I think I can serve this from bun directly in the future.