feat: use async files in webapp#346
Merged
Merged
Conversation
henryiii
force-pushed
the
henryiii/feat/asyncwebapp
branch
from
5b79250 to
33f33c6
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/asyncwebapp
branch
from
33f33c6 to
5dbbe61
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Pyodide-based live demo webapp to use the new async-prefetch flow (from #345) to preload key repository files before running repo-review checks, and updates demo dependency pins accordingly.
Changes:
- Switch webapp compute flow to
prefetch()+collect_checks()+run_process()instead of constructingGHPathsynchronously inrun_process. - Add new Pyodide helper functions for async prefetching and separating collection from processing.
- Update docs/demo dependency pin to a
repo-review1.0.0 release-candidate that includes async support.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/repo-review-app/webapp.tsx | Makes the compute path async and integrates prefetch + collection to support async file loading. |
| src/repo-review-app/utils/pyodide.ts | Adds prefetch() / collect_checks() helpers and updates run_process() to accept collected state. |
| docs/live-demo.md | Updates the demo dependency version to a 1.0.0rc that includes async support. |
| docs/_static/scripts/index.html | Updates the embedded demo dependency version to a 1.0.0rc that includes async support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot address the open review comments. |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #345 in a released version.