Doctests in ufuncs should respect __doctest_skip__#175
Doctests in ufuncs should respect __doctest_skip__#175pllim merged 2 commits intoscientific-python:mainfrom
Conversation
lpsinger
force-pushed
the
doctest-ufunc-skip
branch
from
253c5dd to
32830e9
Compare
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Looks good to me! Definitely makes sense to pass it through the same selection criteria
|
I think we should document how to use |
|
I don't know how I feel about having to add What do others think? |
|
Following recent discussions, I have added back the |
|
Re-running astropy/astropy#12853 🤞 |
|
So.... do we not want to use it over at |
You could revert #12861 if you wanted. |
|
@mhvk , do you really want ufunc doctesting in astropy ? |
|
We don't have that many ufuncs, and I don't think any have examples that would be tested, since they are really for internal use. So, certainly no hurry. On the other hand, long-term we might as well test things in case things change. |
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
astropy core seems fine with this patch. Thanks!
Shall we merge?
|
Thanks! |
|
Thank you! When do you expect to do the next release of pytest-doctestplus? |
This comment was marked as resolved.
This comment was marked as resolved.
|
I'll push a release soon. Stay tuned! |
|
v0.12.0 is released on PyPI. |
5 participants
No description provided.