customize Faraday middleware on RSolr client to do retries on Solr - #1520
Merged
Conversation
jrochkind
force-pushed
the
solr_retry
branch
3 times, most recently
from
December 20, 2021 22:01
affd957 to
0825921
Compare
jrochkind
force-pushed
the
solr_retry
branch
from
December 20, 2021 22:45
0825921 to
1c3f62e
Compare
Contributor
Author
|
Current failure is unrelated to us specifically, seems to be a docker-hub outage, which ends up effecting github CI, cause the whole internet is a network of fragile dependencies now. https://status.docker.com/ |
Unclear how safe this Blacklight API is to use, overriding private method in Repository sub-class. But best thing we found to accomplish Solr retries in Blacklight.
jrochkind
force-pushed
the
solr_retry
branch
from
December 20, 2021 22:56
1c3f62e to
7b5fbed
Compare
jrochkind
marked this pull request as ready for review
January 10, 2022 17:06
Contributor
|
Very cool. Thanks for the tests in particular. |
Contributor
Author
|
Thanks, those tests took me like over a day to figure out, but seemed worth it in this case! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unclear how safe this Blacklight API is to use, overriding private method in Repository sub-class. But best thing we found to accomplish Solr retries in Blacklight.
Needs:
Ref #1365