Widen HTML preferences pane to fit theme controls#467
Merged
Conversation
The HTML preferences pane was 430pt wide, which clipped the CSS theme popup and its Reveal/Reload controls — most visible now that the bundled "GitHub Dark Default" theme ships a long name. The pane is constraint- driven and loadView pins each pane to its XIB design width, so widening the content view to 482pt gives the theme controls room; the inner controls reflow automatically. Adds testHtmlPaneIsWideEnoughForThemeControls to guard the design width against being narrowed back to the cramped value. This reproduces the HTML-pane fix from yusufm's PR #419 on top of #461 (localized text wrapping), preserving #461's checkbox word-wrap. #419's editor-pane rect nudges are omitted: they were design-time-only values, inert under Auto Layout, and overlap #461's rework of that pane. Related to #419. Co-authored-by: yusufm <[email protected]> Claude-Session: https://claude.ai/code/session_0193hY9AbWhec8BuUHCJvHgv
Contributor
Code Coverage ReportCurrent Coverage: 62.03% Coverage Details (Summary) |
Owner
Author
|
Thanks again, @yusufm — CI is fully green across macOS 14/15/15-intel/26, including the regression test guarding the pane width. Credit for the fix is yours; we just rebased it past the conflict we created with #461. Merging now. 🙏 Generated by Claude Code |
schuyler
added
the
rc-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens the HTML preferences pane from 430pt to 482pt so the CSS theme popup and its Reveal/Reload controls stop clipping — most visible now that the bundled "GitHub Dark Default" theme (#465) ships a long name. The pane is fully constraint-driven and
loadViewpins each pane to its XIB design width, so widening the content view is what actually buys the theme controls room; the inner controls reflow automatically.Adds
testHtmlPaneIsWideEnoughForThemeControlsto guard the design width against being narrowed back to the cramped value.Credit / relationship to #419
This reproduces the HTML-pane fix from @yusufm's #419 on top of the recently-merged #461 ("Fix preference pane layout for localized text wrapping"). We merged #461 on top of #419, which created the conflict, so rather than ask the author to untangle our merge we've rebased the fix forward and credited him as co-author. Closes #419 in favor of this PR.
Two deliberate differences from #419:
lineBreakMode="wordWrap"is preserved (the merge resolution on theSyntax highlighted code blockcheckbox).<rect>nudges are omitted. They were 1–2px design-time-only values that are inert under Auto Layout (that pane is constraint-driven) and overlap Fix preference pane layout for localized text wrapping #461's rework of the editor pane.Validation
MPPreferencesViewControllerResizabilityTests(testPanesHaveNoAmbiguousLayout,testContentIsSizedToFitItsContent,testCheckboxTitlesWrap) exercise the widened pane.Related to #419.
https://claude.ai/code/session_0193hY9AbWhec8BuUHCJvHgv
Generated by Claude Code