Skip to content

Add editor invisible character toggle#462

Merged
schuyler merged 1 commit into
mainfrom
claude/affectionate-meitner-nr451d
Jun 22, 2026
Merged

Add editor invisible character toggle#462
schuyler merged 1 commit into
mainfrom
claude/affectionate-meitner-nr451d

Conversation

@schuyler

@schuyler schuyler commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Adds a View-menu Show Invisible Characters toggle, persisted in editor preferences (default off) and applied via the text layout manager's showsInvisibleCharacters.

This is @yusufm's work from #421, rebased onto current main to resolve conflicts in MPDocument.m (the recently-merged autosave toggle and this one each added a branch to validateUserInterfaceItem: and a new action method — both are kept). Authorship preserved.

Supersedes #421 (its branch is on a fork that can't be updated here). Related to #43.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Report

Current Coverage: 61.55%

Coverage Details (Summary)
Name                                                                                                                                   Coverage             
-------------------------------------------------------------------------------------------------------------------------------------- -------------------- 
MASPreferences.bundle                                                                                                                  0.00% (0/0)          
MacDown 3000.app                                                                                                                       62.16% (8864/14259)  
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Utility/MPMathJaxListener.m                                                61.54% (16/26)       
        -[MPMathJaxListener callbacks]                                                                                                 100.00% (5/5)        
        -[MPMathJaxListener addCallback:forKey:]                                                                                       100.00% (3/3)        
        -[MPMathJaxListener invokeCallbackForKey:]                                                                                     100.00% (8/8)        
        +[MPMathJaxListener isSelectorExcludedFromWebScript:]                                                                          0.00% (0/5)          
        +[MPMathJaxListener isKeyExcludedFromWebScript:]                                                                               0.00% (0/5)          
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Document/MPDocument.m                                                      60.60% (1424/2350)   
        MPEditorPreferenceKeyWithValueKey                                                                                              85.71% (6/7)         
        MPEditorKeysToObserve                                                                                                          100.00% (16/16)      
        __MPEditorKeysToObserve_block_invoke                                                                                           100.00% (11/11)      
        MPEditorPreferencesToObserve                                                                                                   100.00% (15/15)      
        __MPEditorPreferencesToObserve_block_invoke                                                                                    100.00% (10/10)      
        MPRectStringForAutosaveName                                                                                                    100.00% (6/6)        
        MPAreNilableStringsEqual                                                                                                       100.00% (3/3)        
        MPGetWebViewBackgroundColor                                                                                                    0.00% (0/10)         
        -[NSURL(Convert) absoluteBaseURLString]                                                                                        0.00% (0/6)          
        -[WebView(Shortcut) enclosingScrollView]                                                                                       100.00% (3/3)        
        -[MPPreferences(Hoedown) extensionFlags]                                                                                       78.57% (22/28)       
        -[MPPreferences(Hoedown) rendererFlags]                                                                                        75.00% (9/12)        
        MPGetPreviewLoadingCompletionHandler                                                                                           100.00% (30/30)      
        __MPGetPreviewLoadingCompletionHandler_block_invoke                                                                            100.00% (27/27)      
        -[MPDocument preferences]                                                                                                      100.00% (3/3)        
        -[MPDocument markdown]                                                                                                         100.00% (3/3)        
        -[MPDocument setMarkdown:]                                                                                                     100.00% (3/3)        
        -[MPDocument html]                                                                                                             0.00% (0/3)          
        -[MPDocument toolbarVisible]                                                                                                   0.00% (0/3)          
        -[MPDocument previewVisible]                                                                                                   100.00% (3/3)        
        -[MPDocument editorVisible]                                                                                                    100.00% (3/3)        
        -[MPDocument needsHtml]                                                                                                        80.00% (4/5)         
        -[MPDocument setTotalWords:]                                                                                                   100.00% (8/8)        
        -[MPDocument setTotalCharacters:]                                                                                              100.00% (8/8)        
        -[MPDocument setTotalCharactersNoSpaces:]                                                                                      100.00% (9/9)        
        -[MPDocument setAutosaveName:]                                                                                                 100.00% (4/4)        
        -[MPDocument mathJaxRenderGeneration]                                                                                          100.00% (3/3)        
        -[MPDocument init]                                                                                                             90.00% (9/10)        
        -[MPDocument windowNibName]                                                                                                    100.00% (3/3)        
        -[MPDocument windowControllerDidLoadNib:]                                                                                      100.00% (105/105)    
        __41-[MPDocument windowControllerDidLoadNib:]_block_invoke                                                                     100.00% (3/3)        
        __41-[MPDocument windowControllerDidLoadNib:]_block_invoke.56                                                                  100.00% (15/15)      
        -[MPDocument reloadFromLoadedString]                                                                                           92.86% (13/14)       
        -[MPDocument close]                                                                                                            12.90% (4/31)        
        +[MPDocument autosavesInPlace]                                                                                                 100.00% (3/3)        
        +[MPDocument writableTypes]                                                                                                    100.00% (3/3)        
        -[MPDocument isDocumentEdited]                                                                                                 100.00% (5/5)        
        -[MPDocument writeToURL:ofType:error:]                                                                                         0.00% (0/28)         
        __38-[MPDocument writeToURL:ofType:error:]_block_invoke                                                                        0.00% (0/3)          

... (3201 more lines truncated)

📊 **Full coverage report available in workflow artifacts**

@schuyler schuyler merged commit fd9426a into main Jun 22, 2026
9 checks passed
@schuyler schuyler deleted the claude/affectionate-meitner-nr451d branch June 22, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants