Skip to content

Add editor invisible character toggle#421

Closed
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/add-editor-whitespace-toggle-019def52-b3da-7962-96cd-afa05d8d1592
Closed

Add editor invisible character toggle#421
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/add-editor-whitespace-toggle-019def52-b3da-7962-96cd-afa05d8d1592

Conversation

@yusufm

@yusufm yusufm commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a View menu toggle for showing invisible editor characters
  • persist the toggle in editor preferences, defaulting off
  • apply the setting through the text layout manager

Tests

schuyler added a commit that referenced this pull request Jun 22, 2026
Adds a View-menu **Show Invisible Characters** toggle, persisted in
editor preferences (default **off**) and applied via the text layout
manager's `showsInvisibleCharacters`.

This is @yusufm's work from #421, rebased onto current `main` to resolve
conflicts in `MPDocument.m` (the recently-merged autosave toggle and
this one each added a branch to `validateUserInterfaceItem:` and a new
action method — both are kept). Authorship preserved.

Supersedes #421 (its branch is on a fork that can't be updated here).
Related to #43.

Co-authored-by: Yusuf Mohsinally <[email protected]>

schuyler commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Thanks, @yusufm! This had drifted into a conflict with main (the recently-merged autosave toggle touched the same validateUserInterfaceItem: chain and added an adjacent action method). Since this PR's branch is on your fork and couldn't be updated from our side, I rebased your commit onto current main, resolved the conflicts (kept both menu branches and both action methods, verified the menu item / preference observation / setupEditor: wiring all survived), preserved your authorship, and merged it via #462. CI was green.

Closing in favor of #462 — the View → Show Invisible Characters toggle is now in main. Appreciate it! 🙏

@schuyler schuyler closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants