Skip to content

Fix preferences layout clipping#419

Closed
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/fix-preferences-layout-clipping-019def52-b3da-7962-96cd-afa05d8d1592
Closed

Fix preferences layout clipping#419
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/fix-preferences-layout-clipping-019def52-b3da-7962-96cd-afa05d8d1592

Conversation

@yusufm

@yusufm yusufm commented May 3, 2026

Copy link
Copy Markdown
Contributor

Related to #397

Summary

  • Widen the HTML preferences pane so the theme reload/reveal controls no longer clip
  • Increase editor preference text field and stepper frames to match current intrinsic sizes
  • Verify HTML, Editor, and General preference XIBs have no ibtool notices/warnings/errors

Tests

  • ibtool --warnings --errors --notices MacDown/Localization/Base.lproj/MPHtmlPreferencesViewController.xib
  • ibtool --warnings --errors --notices MacDown/Localization/Base.lproj/MPEditorPreferencesViewController.xib
  • ibtool --warnings --errors --notices MacDown/Localization/Base.lproj/MPGeneralPreferencesViewController.xib

Copy link
Copy Markdown
Owner

Thanks for this, @yusufm — the horizontal clipping you fixed here is real and still relevant (more so now that the long-named "GitHub Dark Default" theme has landed). Unfortunately we created a conflict for you: we merged #461 (localized text wrapping) on top of this, and the two touch the same controls in the HTML preferences XIB.

Rather than ask you to untangle our merge, I've rebased your HTML-pane fix forward onto current main in #467 and credited you as co-author. It preserves #461's checkbox word-wrap and adds a regression test guarding the pane width. I left out the editor-pane rect nudges since those were design-time-only values that are inert under Auto Layout and overlapped #461's rework of that pane.

Closing in favor of #467 — but please take a look there and let me know if I missed anything. Much appreciated.


Generated by Claude Code

@schuyler schuyler closed this Jun 22, 2026
schuyler added a commit that referenced this pull request Jun 22, 2026
The HTML preferences pane was 430pt wide, which clipped the CSS theme
popup and its Reveal/Reload controls — most visible now that the bundled
"GitHub Dark Default" theme ships a long name. The pane is constraint-
driven and loadView pins each pane to its XIB design width, so widening
the content view to 482pt gives the theme controls room; the inner
controls reflow automatically. Adds a regression test guarding the width.

Reproduces the HTML-pane fix from yusufm's #419 on top of #461, preserving
#461's checkbox word-wrap.

Related to #419.

Co-authored-by: yusufm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants