Clear editor highlighting on reload#415
Merged
schuyler merged 1 commit intoJun 22, 2026
Merged
Conversation
schuyler
approved these changes
Jun 22, 2026
schuyler
left a comment
schuyler
left a comment
Owner
There was a problem hiding this comment.
Looks great — thanks @yusufm. The clearHighlighting → readClearTextStylesFromTextView → parseAndHighlightNow sequence correctly mirrors the highlighter's own ordering in applyStylesFromStylesheet:, and since parseAndHighlightNow only schedules an async parse, the explicit synchronous clear is what actually closes the stale-attribute gap from #378. Nice regression test too. Approving.
Generated by Claude Code
schuyler
added
the
rc-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #378.
Validation
Note: the last only-testing selector is not present on main, so Xcode ran the two matching lifecycle tests.