Skip to content

Add File menu autosave toggle#412

Closed
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/add-file-menu-autosave-toggle-019def52-b3da-7962-96cd-afa05d8d1592
Closed

Add File menu autosave toggle#412
yusufm wants to merge 1 commit into
schuyler:mainfrom
yusufm:Codex/add-file-menu-autosave-toggle-019def52-b3da-7962-96cd-afa05d8d1592

Conversation

@yusufm

@yusufm yusufm commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an Auto Save toggle to the File menu
  • Wire the toggle to the existing editorAutoSave preference used by MPDocument.autosavesInPlace
  • Keep the menu item checked/unchecked through standard menu validation

Root cause

Autosave could already be disabled through preferences, but there was no fast document-menu control for users who want prompt-on-close behavior after disabling autosave.

Validation

  • ibtool --warnings --errors --notices MacDown/Localization/Base.lproj/MainMenu.xib
  • xcodebuild test -workspace 'MacDown 3000.xcworkspace' -scheme MacDown -destination 'platform=macOS' -only-testing:MacDownTests/MPDocumentIOTests/testAutosavesInPlaceRespectsPreference -only-testing:MacDownTests/MPDocumentIOTests/testToggleAutoSaveActionUpdatesPreference -only-testing:MacDownTests/MPDocumentIOTests/testToggleAutoSaveMenuValidationReflectsPreference

Related to #301

@yusufm yusufm marked this pull request as ready for review May 3, 2026 20:34

Copy link
Copy Markdown
Owner

Thanks, @yusufm! Wiring a File-menu Auto Save toggle to the existing editorAutoSave preference with proper menu-item validation is clean and self-contained, and the tests covering both the action and the validation state are a nice addition. CI is green. Appreciate the contribution! 🙏


Generated by Claude Code

schuyler added a commit that referenced this pull request Jun 22, 2026
Adds an **Auto Save** toggle to the File menu, wired to the existing
`editorAutoSave` preference (used by `MPDocument.autosavesInPlace`),
with standard menu-item validation keeping it checked/unchecked.

This is @yusufm's work from #412, rebased onto current `main` to resolve
a conflict in `MPDocumentIOTests.m` (both that PR and a since-merged
change added a method declaration to the same test category interface —
both are kept). The original commit and authorship are preserved.

Supersedes #412 (which targets a fork branch that can't be updated
here). Related to #301.

https://claude.ai/code/session_0137UcTVyFufiiUXv2mtDPpj

---
_Generated by [Claude
Code](https://claude.ai/code/session_0137UcTVyFufiiUXv2mtDPpj)_

Co-authored-by: Yusuf Mohsinally <[email protected]>

Copy link
Copy Markdown
Owner

Thanks again, @yusufm! This had drifted into a merge conflict with main (a since-merged change added a method declaration to the same MPDocumentIOTests.m category interface). Since this PR's branch lives on your fork and couldn't be updated from our side, I rebased your commit onto current main, resolved the conflict (kept both declarations), preserved your authorship, and merged it via #459. CI was green.

Closing in favor of #459 — the change (File menu Auto Save toggle) is now in main. Appreciate the contribution! 🙏


Generated by Claude Code

@schuyler schuyler closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants