Skip to content

Sort editor theme and rendering CSS preference menus#404

Merged
schuyler merged 1 commit into
mainfrom
claude/port-macdown-1371-2VmmE
Apr 26, 2026
Merged

Sort editor theme and rendering CSS preference menus#404
schuyler merged 1 commit into
mainfrom
claude/port-macdown-1371-2VmmE

Conversation

@schuyler

@schuyler schuyler commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Sort the Theme (Editor) and CSS (Rendering) popup lists in Preferences alphabetically using localizedStandardCompare: so entries are easier to discover.

Ported from upstream macdownapp/macdown#1371 by @lexblagus.

Test plan

  • Open Preferences → Editor and confirm the Theme dropdown is sorted alphabetically (locale-aware).
  • Open Preferences → Rendering and confirm the CSS dropdown is sorted alphabetically.
  • CI build passes on macOS.

Generated by Claude Code

@claude
Sort editor theme and rendering CSS preference menus
c09d456 
Apply localizedStandardCompare: so the Theme (Editor) and CSS
(Rendering) popup lists in Preferences appear in ascending order,
making entries easier to discover.

Ported from MacDownApp/macdown#1371.
@github-actions

github-actions Bot commented Apr 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Coverage Report

Current Coverage: 60.45%

Coverage Details (Summary) 
Name                                                                                                                                   Coverage            
-------------------------------------------------------------------------------------------------------------------------------------- ------------------- 
MASPreferences.bundle                                                                                                                  0.00% (0/0)         
MacDown 3000.app                                                                                                                       62.05% (8724/14059) 
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Extension/DOMNode+Text.m                                                   99.02% (101/102)    
        MPAccumulatedTextCountMake                                                                                                     100.00% (7/7)       
        MPAccumulatedTextCountZero                                                                                                     100.00% (3/3)       
        MPAccumulatedTextCountAdd                                                                                                      100.00% (5/5)       
        MPGetStringAccumulatedTextCount                                                                                                97.06% (33/34)      
        __MPGetStringAccumulatedTextCount_block_invoke                                                                                 100.00% (3/3)       
        __MPGetStringAccumulatedTextCount_block_invoke.30                                                                              100.00% (4/4)       
        MPGetChildrenAccumulatedTextCount                                                                                              100.00% (6/6)       
        MPGetNodeAccumulatedTextCount                                                                                                  100.00% (32/32)     
        -[DOMNode(Text) textCount]                                                                                                     100.00% (8/8)       
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Document/MPDocument.m                                                      60.43% (1356/2244)  
        MPEditorPreferenceKeyWithValueKey                                                                                              85.71% (6/7)        
        MPEditorKeysToObserve                                                                                                          100.00% (15/15)     
        __MPEditorKeysToObserve_block_invoke                                                                                           100.00% (10/10)     
        MPEditorPreferencesToObserve                                                                                                   100.00% (14/14)     
        __MPEditorPreferencesToObserve_block_invoke                                                                                    100.00% (9/9)       
        MPRectStringForAutosaveName                                                                                                    100.00% (6/6)       
        MPAreNilableStringsEqual                                                                                                       100.00% (3/3)       
        MPGetWebViewBackgroundColor                                                                                                    0.00% (0/9)         
        -[NSURL(Convert) absoluteBaseURLString]                                                                                        0.00% (0/6)         
        -[WebView(Shortcut) enclosingScrollView]                                                                                       100.00% (3/3)       
        -[MPPreferences(Hoedown) extensionFlags]                                                                                       78.57% (22/28)      
        -[MPPreferences(Hoedown) rendererFlags]                                                                                        75.00% (9/12)       
        MPGetPreviewLoadingCompletionHandler                                                                                           100.00% (30/30)     
        __MPGetPreviewLoadingCompletionHandler_block_invoke                                                                            100.00% (27/27)     
        -[MPDocument preferences]                                                                                                      100.00% (3/3)       
        -[MPDocument markdown]                                                                                                         100.00% (3/3)       
        -[MPDocument setMarkdown:]                                                                                                     100.00% (3/3)       
        -[MPDocument html]                                                                                                             0.00% (0/3)         
        -[MPDocument toolbarVisible]                                                                                                   0.00% (0/3)         
        -[MPDocument previewVisible]                                                                                                   100.00% (3/3)       
        -[MPDocument editorVisible]                                                                                                    100.00% (3/3)       
        -[MPDocument needsHtml]                                                                                                        80.00% (4/5)        
        -[MPDocument setTotalWords:]                                                                                                   100.00% (7/7)       
        -[MPDocument setTotalCharacters:]                                                                                              100.00% (7/7)       
        -[MPDocument setTotalCharactersNoSpaces:]                                                                                      100.00% (8/8)       
        -[MPDocument setAutosaveName:]                                                                                                 100.00% (4/4)       
        -[MPDocument mathJaxRenderGeneration]                                                                                          100.00% (3/3)       
        -[MPDocument init]                                                                                                             90.00% (9/10)       
        -[MPDocument windowNibName]                                                                                                    100.00% (3/3)       
        -[MPDocument windowControllerDidLoadNib:]                                                                                      100.00% (105/105)   
        __41-[MPDocument windowControllerDidLoadNib:]_block_invoke                                                                     100.00% (3/3)       
        __41-[MPDocument windowControllerDidLoadNib:]_block_invoke.239                                                                 100.00% (15/15)     
        -[MPDocument reloadFromLoadedString]                                                                                           92.86% (13/14)      
        -[MPDocument close]                                                                                                            12.90% (4/31)       
        +[MPDocument autosavesInPlace]                                                                                                 100.00% (3/3)       

... (3168 more lines truncated)

📊 **Full coverage report available in workflow artifacts**

@schuyler schuyler mentioned this pull request Apr 26, 2026
Closed
@schuyler schuyler merged commit cec80ed into main Apr 26, 2026
9 checks passed
@schuyler schuyler deleted the claude/port-macdown-1371-2VmmE branch April 26, 2026 08:16
@schuyler schuyler added the rc-pending Included in a release candidate awaiting validation label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rc-pending Included in a release candidate awaiting validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schuyler @claude