Fix preview scroll jump when MathJax is enabled (#325)#330
Merged
Conversation
Remove the MathJax exclusion from the DOM replacement condition so that MathJax-enabled documents use the fast DOM replacement path instead of a full WebView reload on every keystroke. The existing MathJax.Hub.Queue mechanism correctly serializes async typesetting and scroll restoration. Add a post-typesetting callback via MPMathJaxListener to update header locations after MathJax rendering changes document height, ensuring scroll sync remains accurate. Related to #325 https://claude.ai/code/session_01D99FSveFtEM8szRX6f74iN
Add #import "MPRenderer.h" to resolve unknown type errors in tests. Add clarifying comment about MathJaxListener overwriting safety. Fix copyright year to 2026. Related to #325 https://claude.ai/code/session_01D99FSveFtEM8szRX6f74iN
schuyler
force-pushed
the
claude/issue-325-ZxTvL
branch
from
07b6e3d to
d1107ff
Compare
Contributor
Code Coverage ReportCurrent Coverage: 56.80% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPMathJaxListenerto update header locations after MathJax rendering changes document height, keeping scroll sync accuratelastPreviewScrollTopduring DOM replacement for scroll position preservationTest plan
MPMathJaxScrollTests.mcovering DOM replacement condition logic, listener callbacks, state management, and scroll preservationRelated to #325
https://claude.ai/code/session_01D99FSveFtEM8szRX6f74iN