Fix main thread crash in userDefaultsDidChange: (#320)#323
Merged
Conversation
…efaultsDidChangeNotification NSUserDefaultsDidChangeNotification can fire from background threads (observed on macOS 15 during XCTest bootstrap), causing userDefaultsDidChange: to access NSTextView off the main thread, triggering a Main Thread Checker crash. Switch from addObserver:selector:name:object: to addObserverForName:object:queue:usingBlock: with [NSOperationQueue mainQueue] to guarantee main-thread delivery. Store the returned opaque observer token as a property and explicitly remove it in close. Related to #320 https://claude.ai/code/session_01JrSNCCvdharCeVAoFYw3vq
Contributor
Code Coverage ReportCurrent Coverage: 55.20% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSUserDefaultsDidChangeNotificationobserver with block-basedaddObserverForName:object:queue:usingBlock:using[NSOperationQueue mainQueue]to guarantee main-thread deliverycloseProblem
NSUserDefaultsDidChangeNotificationcan fire from background threads (observed on macOS 15 during XCTest bootstrap), causinguserDefaultsDidChange:to accessNSTextViewoff the main thread, triggering a Main Thread Checker crash.Changes
MacDown/Code/Document/MPDocument.m(3 localized changes):userDefaultsObserverTokenproperty in class extension[NSOperationQueue mainQueue]+__weak selfclosebefore the blanketremoveObserver:selfMacDownTests/MPNotificationTests.m(1 new test):testUserDefaultsNotificationFromBackgroundThreadDeliveredOnMainThread— posts notification from background thread, asserts main-thread deliveryTest plan
Related to #320