Address issue #314: Help Menu Behaviors#319
Merged
Merged
Conversation
Stop forcing Help and Contributing documents to fill the entire visible screen. Instead, let the standard document window sizing logic handle it — new windows open at the default size (1024x578) centered on screen, and tabbed windows keep their existing size. Also add a "MacDown 3000 on GitHub" menu item to the Help menu that opens the project repository in the default browser. Related to #314 https://claude.ai/code/session_01Qm5muspbe4LDuGqPZPmyWD
Apply the same fix to openUrlSchemeAppleEvent: — stop forcing documents opened via x-macdown:// URL scheme to fill the entire visible screen. Let standard document window sizing handle it. Related to #314 https://claude.ai/code/session_01Qm5muspbe4LDuGqPZPmyWD
Contributor
Code Coverage ReportCurrent Coverage: 54.52% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Related to #314
Changes
MacDown/Code/Application/MPMainController.mMPOpenBundledFile(): Replaced the custom completion handler that forced[NSScreen mainScreen].visibleFramesizing withMPDocumentOpenCompletionEmpty(no-op). This letsMPDocument.windowControllerDidLoadNib:handle sizing naturally.openUrlSchemeAppleEvent:withReplyEvent:: Same fix — removed forced full-screen sizing for documents opened viax-macdown://URL scheme.openGitHub:: New IBAction that opens the project GitHub URL in the default browser.MacDown/Localization/Base.lproj/MainMenu.xibopenGitHub:onMPMainController.Manual Testing Plan
x-macdown://open?url=...should no longer force full-screen sizing.