Fix Issue #293: Disable intra-word emphasis by default#295
Merged
Conversation
Filenames with underscores (e.g., File_Name_With_Underscores.md) were being partially italicized because the extensionIntraEmphasis preference defaulted to YES, allowing Hoedown to interpret underscores as emphasis markers. Changes: - Change extensionIntraEmphasis default from YES to NO in loadDefaultPreferences - Refactor existing boolean migration flags into a version-based system: - Version 1: Substitution defaults fix (Issue #263) - Version 2: Task list default fix (Issue #269) - Version 3: Intra-emphasis default fix (Issue #293) - Add effectiveMigrationVersion method to infer version from legacy flags - Add comprehensive tests for the migration system The migration ensures all users (new and existing) get the fix automatically. Users who prefer intra-word emphasis can re-enable it in Preferences > Markdown. Related to #293 https://claude.ai/code/session_018KTdsSojt6tBo9PLmU3Nsi
Update the checkbox/task list migration tests (Issue #269) to work with the new version-based migration system. The tests now also save/restore and set/clear MPMigrationVersion to properly simulate fresh installs and migrated users. Related to #293 https://claude.ai/code/session_018KTdsSojt6tBo9PLmU3Nsi
Contributor
Code Coverage ReportCurrent Coverage: 54.02% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filenames with underscores (e.g.,
File_Name_With_Underscores.md) were being partially italicized in the preview pane because theextensionIntraEmphasispreference defaulted toYES, allowing Hoedown to interpret underscores as emphasis markers.This PR:
extensionIntraEmphasisdefault fromYEStoNORelated Issue
Related to #293
Changes
MPPreferences.m
extensionIntraEmphasis = YEStoextensionIntraEmphasis = NOinloadDefaultPreferencesloadDefaultUserDefaultsto useapplyPreferencesMigrationseffectiveMigrationVersionmethod to infer version from legacy boolean flagsapplyPreferencesMigrationsmethod with version-based migration:MPPreferencesTests.m
Manual Testing Plan
Test content:
Review Notes