Skip to content

Commit 6ba81b3

Browse files
schenksjclaude
andcommitted
docs(serde): point CometCreateArray decline at upstream tracking issue
Adds a TODO note linking the decline-and-fallback to apache/datafusion#22366. Lets a future maintainer find the upstream fix when it lands and remove the workaround. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 3005d6e commit 6ba81b3

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎spark/src/main/scala/org/apache/comet/serde/arrays.scala‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,10 @@ object CometCreateArray extends CometExpressionSerde[CreateArray] {
490490
// another. Native execution then panics inside `make_array_inner`. Decline here
491491
// when any pair of children disagree on data type so Spark's JVM evaluator
492492
// (which doesn't have this strictness) handles it.
493+
//
494+
// TODO: remove this decline once apache/datafusion#22366 lands. The upstream fix
495+
// will widen the element type via nullability-OR-merge and cast each child before
496+
// handing to MutableArrayData, eliminating the need for this caller-side workaround.
493497
val childTypes = children.map(_.dataType)
494498
if (childTypes.distinct.size > 1) {
495499
withInfo(

0 commit comments

Comments
 (0)