get latest inference framework tag from configmap#505
Merged
saiatmakuri merged 9 commits intomainfrom May 3, 2024
Merged
Conversation
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Show resolved
Hide resolved
| raise LatestImageTagNotFoundException( | ||
| f"Could not find latest tag for inference framework {inference_framework}." | ||
| ) | ||
| return config_map[inference_framework] |
Contributor
There was a problem hiding this comment.
let's also check whether the image actually exists
Contributor
Author
There was a problem hiding this comment.
this happens later in the creation process
Contributor
There was a problem hiding this comment.
you meant within create_llm_model_bundle_use_case.execute?
Contributor
Author
There was a problem hiding this comment.
we first map "latest" to the value from the config map. then in create_llm_model_bundle_use_case.execute that tag is checked
yunfeng-scale
approved these changes
May 3, 2024
| raise LatestImageTagNotFoundException( | ||
| f"Could not find latest tag for inference framework {inference_framework}." | ||
| ) | ||
| return config_map[inference_framework] |
Contributor
There was a problem hiding this comment.
you meant within create_llm_model_bundle_use_case.execute?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
use a remote configmap to manage latest inference framework versions
Test Plan and Usage Guide
try create request with
"latest"tag with "vllm" and "tensortrt_llm" frameworks