Fix throughput_benchmarks ITL calculation, add option to use a json file of prompts#485
Merged
seanshi-scale merged 7 commits intomainfrom Apr 10, 2024
Merged
Conversation
seanshi-scale
changed the title
yunfeng-scale
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
We need to skip blank token responses, this largely only affects the reported percentiles of the inter-token latencies.
Also add option to read in a list of prompts from some json file
Test Plan and Usage Guide
Script works, ITL percentiles look reasonable.