Merged
Conversation
saiatmakuri
reviewed
Apr 1, 2024
model-engine/model_engine_server/inference/batch_inference/vllm_batch.py
Outdated
Show resolved
Hide resolved
model-engine/model_engine_server/inference/batch_inference/vllm_batch.py
Outdated
Show resolved
Hide resolved
edgan8
reviewed
Apr 1, 2024
| ) | ||
| statsd.increment( | ||
| "model_engine.batch_inference.vllm.token_count.total", | ||
| num_prompt_tokens + num_completion_tokens, |
Contributor
There was a problem hiding this comment.
Is this possible to just compute when querying metrics later?
Contributor
There was a problem hiding this comment.
I think if we do increment we can just add them later, but if we want to do something more fancy like histogram/distribution then we need to output the total separately
Contributor
Author
There was a problem hiding this comment.
yes it is possible, also things like Sean said
model-engine/model_engine_server/inference/batch_inference/vllm_batch.py
Outdated
Show resolved
Hide resolved
edgan8
reviewed
Apr 2, 2024
model-engine/model_engine_server/inference/batch_inference/vllm_batch.py
Show resolved
Hide resolved
model-engine/model_engine_server/inference/batch_inference/vllm_batch.py
Outdated
Show resolved
Hide resolved
edgan8
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
add some metrics to batch jobs
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.