Skip to content

Add log statement for gateway sending async task#459

Merged
tiffzhao5 merged 3 commits intomainfrom
tiffany/async-obs
Feb 28, 2024
Merged

Add log statement for gateway sending async task#459
tiffzhao5 merged 3 commits intomainfrom
tiffany/async-obs

Conversation

@tiffzhao5
Copy link
Copy Markdown
Contributor

Pull Request Summary

Add dd log statement when a celery task is added to the queue for async tasks.

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@tiffzhao5 tiffzhao5 requested review from a team and song-william February 28, 2024 01:36
Copy link
Copy Markdown
Contributor

@yunfeng-scale yunfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for some debugging?

@song-william
Copy link
Copy Markdown
Contributor

is this for some debugging?

If someone does a text search for "task_id", they can now find in the logs when the task was initially put on the queue by the gateway. Previously this info was missing from the logs.

@tiffzhao5 tiffzhao5 enabled auto-merge (squash) February 28, 2024 18:25
@tiffzhao5 tiffzhao5 merged commit f9a3ff5 into main Feb 28, 2024
@tiffzhao5 tiffzhao5 deleted the tiffany/async-obs branch February 28, 2024 18:49
@yunfeng-scale yunfeng-scale mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants