Skip to content

[Client] Add Auth headers to the python async routes#434

Merged
seanshi-scale merged 2 commits intomainfrom
seanshi/fix-async-client-request-headers
Feb 7, 2024
Merged

[Client] Add Auth headers to the python async routes#434
seanshi-scale merged 2 commits intomainfrom
seanshi/fix-async-client-request-headers

Conversation

@seanshi-scale
Copy link
Copy Markdown
Contributor

@seanshi-scale seanshi-scale commented Feb 7, 2024 •
edited
Loading

Pull Request Summary

Add Basic Auth headers when people use the client's python async routes

Test Plan and Usage Guide

Setting LLM_ENGINE_BASE_PATH to a self-hosted LLM Engine:

import asyncio
from llmengine import Completion
asyncio.run(Completion.acreate(model='llama-2-7b-chat', prompt='prompt'))

works. Without the change, we get

<stack trace>
llmengine.errors.UnauthorizedError: No authentication was passed in

@seanshi-scale seanshi-scale self-assigned this Feb 7, 2024
@seanshi-scale seanshi-scale enabled auto-merge (squash) February 7, 2024 19:05
@seanshi-scale seanshi-scale merged commit e07fc7a into main Feb 7, 2024
@seanshi-scale seanshi-scale deleted the seanshi/fix-async-client-request-headers branch February 7, 2024 19:11
@yunfeng-scale yunfeng-scale mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squeakymouse squeakymouse Awaiting requested review from squeakymouse

@song-william song-william Awaiting requested review from song-william

@saiatmakuri saiatmakuri Awaiting requested review from saiatmakuri

1 more reviewer

@ian-scale ian-scale ian-scale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seanshi-scale seanshi-scale

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanshi-scale @ian-scale