Azure refactor for async endpoints#425
Merged
squeakymouse merged 42 commits intomainfrom Feb 20, 2024
Merged
Conversation
| ), | ||
| ) | ||
| engine_url = client.get_secret(key_file).value | ||
| logger.info(f"Connecting to db {engine_url}") |
Contributor
There was a problem hiding this comment.
i think this would expose password?
yunfeng-scale
approved these changes
Feb 1, 2024
.circleci/config.yml
Outdated
| curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube_latest_amd64.deb | ||
| sudo dpkg -i minikube_latest_amd64.deb | ||
| minikube start --vm-driver=docker --kubernetes-version=v1.23.0 --memory=49152 --cpus=14 | ||
| minikube start --vm-driver=docker --kubernetes-version=v1.27.7 --memory=49152 --cpus=14 |
Contributor
There was a problem hiding this comment.
hmm, would this require a cluster update for production clusters?
| infra: | ||
| # cloud_provider [required]; either "aws" or "azure" | ||
| cloud_provider: aws | ||
| # k8s_cluster_name [required] is the name of the k8s cluster |
Contributor
There was a problem hiding this comment.
some of the config values seem to be only used with aws, like default_region, ml_account_id, s3_bucket, sqs stuff. not need to be done in this PR, but we should move them into aws config section
… kubernetes_asyncio version?
…ce_delegate changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Azure support for a very limited subset of functionality; the only one needed right now is async endpoint creation and inference
Test Plan and Usage Guide
Deployed to an Azure test cluster