Skip to content

Validating inference framework image tags#357

Merged
tiffzhao5 merged 16 commits intomainfrom
tiffany/validate
Nov 9, 2023
Merged

Validating inference framework image tags#357
tiffzhao5 merged 16 commits intomainfrom
tiffany/validate

Conversation

@tiffzhao5
Copy link
Copy Markdown
Contributor

@tiffzhao5 tiffzhao5 commented Nov 1, 2023 •
edited
Loading

Added unit test to this: #338

Needed to rebase so created a separate PR.

Querying ECR to check for existing images for each inference framework.

@tiffzhao5 tiffzhao5 requested a review from ian-scale November 1, 2023 20:15
@yunfeng-scale
Copy link
Copy Markdown
Contributor

yunfeng-scale commented Nov 1, 2023

thanks for the contributions!

i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

@tiffzhao5
Copy link
Copy Markdown
Contributor Author

tiffzhao5 commented Nov 2, 2023

thanks for the contributions!

i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

hm I see that's a good suggestion, I'll give it a try and see if it works!

@tiffzhao5 tiffzhao5 changed the title Unit test for validating inference framework image tags Validating inference framework image tags Nov 3, 2023
@tiffzhao5
Copy link
Copy Markdown
Contributor Author

tiffzhao5 commented Nov 6, 2023

thanks for the contributions!
i'm worried about the overhead of adding these tags / redeploy model engine server whenever we're adding a new image. possible to query ECR and check existence of the image?

hm I see that's a good suggestion, I'll give it a try and see if it works!

@yunfeng-scale I implemented querying ECR -- what are your thoughts?

@yunfeng-scale
Copy link
Copy Markdown
Contributor

yunfeng-scale commented Nov 7, 2023

it seems a some commits were reverted, can you bring them back?

yunfeng-scale
yunfeng-scale approved these changes Nov 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yunfeng-scale yunfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix @yixu34 's comment

@tiffzhao5 tiffzhao5 enabled auto-merge (squash) November 9, 2023 02:20
@tiffzhao5 tiffzhao5 merged commit a5dbfa5 into main Nov 9, 2023
@tiffzhao5 tiffzhao5 deleted the tiffany/validate branch November 9, 2023 02:38
@yixu34 yixu34 mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yixu34 yixu34 yixu34 left review comments

+2 more reviewers

@ian-scale ian-scale ian-scale left review comments

@yunfeng-scale yunfeng-scale yunfeng-scale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiffzhao5 @yunfeng-scale @yixu34 @ian-scale @ian-scale-2