Conversation
|
we should remove |
yes once the other changes I'm adding work, but still waiting to make sure integration tests pass locally |
are we skipping auth for circleci integration tests? |
…gine into ianmacleod/use_real_auth
integration_tests/test_fine_tunes.py
Outdated
| @@ -1,7 +1,10 @@ | |||
| """ | |||
There was a problem hiding this comment.
this test was already not functioning so I commented everything out - todo later is come through and fix it so that it works.
There was a problem hiding this comment.
Mind creating a follow-up ticket for this?
There was a problem hiding this comment.
yeah sounds good!
integration_tests/test_fine_tunes.py
Outdated
| @@ -1,7 +1,10 @@ | |||
| """ | |||
There was a problem hiding this comment.
Mind creating a follow-up ticket for this?
integration_tests/rest_api_utils.py
Outdated
| USER_ID_1, | ||
| ) | ||
| # Use the scale-launch-integration-tests id | ||
| USER_ID_0 = os.getenv("TEST_USER_ID") # type: ignore |
There was a problem hiding this comment.
set some default value
There was a problem hiding this comment.
and i think None USER_ID_0 caused integration test to fail
There was a problem hiding this comment.
agreed, I set a default value of "fakeuser", this should pass CI since we don't use the auth repo in CI currently
integration_tests/test_fine_tunes.py
Outdated
|
|
||
| # cancel_response = cancel_fine_tune_by_id(fine_tune_id, USER_ID_0) | ||
| # assert cancel_response["success"] | ||
| # list_response_1 = list_fine_tunes(USER_ID_0) |
There was a problem hiding this comment.
there should be some @pytest.skip(reason="test doesn't work") thing that you can do to skip the test (as opposed to commenting it out)
There was a problem hiding this comment.
yeah let me add this too - although I will say the test was already doing nothing, just asserting that the list of fine tunes for the user was empty
…gine into ianmacleod/use_real_auth
5 participants
No description provided.