Skip to content

llama should have None max length#348

Merged
sam-scale merged 1 commit intomainfrom
ss/llama-none-max-length
Oct 24, 2023
Merged

llama should have None max length#348
sam-scale merged 1 commit intomainfrom
ss/llama-none-max-length

Conversation

@sam-scale
Copy link
Copy Markdown
Contributor

No description provided.

# Based on config here: https://huggingface.co/codellama/CodeLlama-7b-hf/blob/main/config.json#L12
# Can also see 13B, 34B there too
"llama-2": {"max_model_len": 4096, "max_num_batched_tokens": 4096},
"llama-2": {"max_model_len": None, "max_num_batched_tokens": 4096},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with vllm-project/vllm#1198 i think we can remove setting max_num_batched_tokens. this is merged in 0.2.0

@sam-scale
Copy link
Copy Markdown
Contributor Author

Going to merge for now to unblock people and then check if we don't need these anymore

@sam-scale sam-scale merged commit d2d4d10 into main Oct 24, 2023
@sam-scale sam-scale deleted the ss/llama-none-max-length branch October 24, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants