Hardcode number of forwarder workers#334
Merged
yunfeng-scale merged 4 commits intomainfrom Oct 20, 2023
Merged
Conversation
yixu34
approved these changes
Oct 19, 2023
yunfeng-scale
commented
Oct 20, 2023
| {{- end }} | ||
| - --num-workers | ||
| - "${PER_WORKER}" | ||
| - "${FORWARDER_WORKER_COUNT}" |
Contributor
Author
There was a problem hiding this comment.
we always just have one celery worker and per_worker is used to determine the concurrency https://github.com/scaleapi/llm-engine/blob/main/model-engine/model_engine_server/inference/forwarding/celery_forwarder.py#L141
Contributor
There was a problem hiding this comment.
imo we could think of ways to maybe increase the number of celery tasks in flight to increase async task throughput, which may involve increasing number of workers, maybe not super necessary now though
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hardcode to use 2 http forwarder workers: